[U-Boot-Users] [PATCH 4/4] TQM885D: Use the OSCM, feeded by EXTAL = 10 MHz.

[Wolfgang Denk]

In message <20070724085849.20151.20950.stgit at tq-sewsrv-4.tq-net.de> you wrote:
> From: Jens Gehrlein <jens.gehrlein at tqs.de>
> 
> This makes it necessary to prescale PITCLK by 512.
> 
> This patch is necessary for revision 102 and above of the TQM885D.
> Revisions 100 and 101 of the TQM885D will not work with this patch
> applied. But this should not be a problem, since there are only
> a few prototypes of this revisions floating around.
> 
> Signed-off-by: Jens Gehrlein <jens.gehrlein at tqs.de>
> Signed-off-by: Martin Krause <martin.krause at tqs.de>

NAK by Wolfgang Denk.

> diff --git a/cpu/mpc8xx/speed.c b/cpu/mpc8xx/speed.c
> index 101d5f9..4173092 100644
> --- a/cpu/mpc8xx/speed.c
> +++ b/cpu/mpc8xx/speed.c
> @@ -93,11 +93,23 @@ unsigned long measure_gclk(void)
>  	ulong msr_val;
>  
>  #ifdef CFG_8XX_XIN
> +#ifdef CONFIG_TQM885D

I don't allow for board specific code in that file (and please get rid
of the other "#if defined(CONFIG_TQM885D)" that's already there while
you are at it).

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The glory of creation is in its infinite diversity." "And in the way
our differences combine to create meaning and beauty."
	-- Dr. Miranda Jones and Spock, "Is There in Truth No Beauty?",
	   stardate 5630.8