[U-Boot-Users] [PATCH 2/2] Add support for SBC8641D

[Ben Warren]

Joe Hamman wrote:
<snip>
> +
> +/*
> + * Environment Configuration
> + */
> +
> +/* The mac addresses for all ethernet interface */
> +#if defined(CONFIG_TSEC_ENET)
> +#define CONFIG_ETHADDR   00:E0:0C:00:00:01
> +#define CONFIG_ETH1ADDR  00:E0:0C:00:01:FD
> +#define CONFIG_ETH2ADDR  00:E0:0C:00:02:FD
> +#define CONFIG_ETH3ADDR  00:E0:0C:00:03:FD
> +#endif
>   
If you're going to default MAC addresses (which IMHO is a bad idea), 
they should be private ones (i.e. bit 41 is set).  The ones you've 
listed belong to somebody (or more likely some faceless organization).  
It would be better to leave these out and make the user program them at 
board bring-up.

regards,
Ben