[U-Boot-Users] [PATCH] Added support for multiple serial for MPC8XX

Wolfgang Denk wd at denx.de
Tue Jun 5 15:56:41 CEST 2007


Hi Stefano,

I wrote:

> Maybe we can use something more readable like
> 
> 	#define	CONFIG_CONS_DEV	smc1
> or
> 	#define CONFIG_CONS_DEV scc3
> 
> in the board config file, and then add a little CPP trickery like that
> to common/serial.c:
> 
> 	#define MK_DEV(dev) _MK_DEV(dev)
> 	#define _MK_DEV(dev) serial_ ## dev ## _device
> 
> Then we can replace this whole block of unreadble code by something
> like
> 
> 	return MK_DEV(CONFIG_CONS_DEV);

Please make this

	return &MK_DEV(CONFIG_CONS_DEV);

or it won't work...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Mike's Law: For a lumber company employing two men and a cut-off saw,
the marginal product of labor for any number  of  additional  workers
equals  zero  until the acquisition of another cut-off saw. Let's not
even consider a chainsaw.
- Mike Dennison [You could always  schedule the saw, though - ed.]




More information about the U-Boot mailing list