[U-Boot-Users] [PATCH] Added support for multiple serial for MPC8XX

Stefano Babic sbabic at denx.de
Wed Jun 6 15:03:01 CEST 2007


On Wednesday 06 June 2007 01:49, Wolfgang Denk wrote:
> We should get rid of all this CONFIG_CONS_INDEX stuff.
>

CONFIG_CONS_INDEX has a useful meaning inside the NS16550 driver, so I do not 
drop it. I removed only the mess inside common/serial.c in the same way as 
you suggested for the mpc8xx.

> Please feel free to fix it for the existing 4xx boards as well. I'd
> really appreciate this, and I even volunteer to test it on a few of
> them.

If I am not wrong, only the mcc200 board for ppc4xx needs multiple serial 
interfaces and uses the NS16550 driver, requiring some testing.

The PPC5200 based boards (the only other architecture using multiple serials) 
do not use the NS16450 and they rely on the PSC driver, configured by the 
CONFIG_UART1_CONSOLE (and I do not change this mechanism).

I have also noted that CONFIG_SERIAL_MULTI is always on for the mpc8xx (set 
implicitely by include/common.h and not by the board config file), even if 
there was no full support to have multiple serial interfaces. 
I think this gave us the nice feature to have in a easy way one SMC and one 
SCC and to switch between them (but not two SMCs or multiple SCCs), but
now with full support for multiple interfaces I think this behavior is wrong 
and I removed it (it breaks all mpc8xx boards requiring to configure the 
default console). Multiple interfaces must be enabled setting explicitely  
CONFIG_SERIAL_MULTI in their config file. And at the moment, there is no 
board where more that one CONFIG_8xx_CONS_XXX is set.

Regards,
stefano babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================




More information about the U-Boot mailing list