[U-Boot-Users] [PATCH 2/3] Added USB PCI-OHCI chips support, interrupt pipe support and usb event poll support.

[Zhang Wei-r63237]

Hi, Markus,

Thanks so much!

Jason help us to test it. He find a bug in your patch "USB/OHCI: endianness cleanup in the generic ohci driver" as below:

-#define readl(a) m32_swap(*((vu_long *)(a)))
-#define writel(a, b) (*((vu_long *)(b)) = m32_swap((vu_long)a))
+/*
+ * e.g. PCI controllers need this
+ */
+#ifdef CFG_OHCI_SWAP_REG_ACCESS
+# define readl(a) __swap_16(*((vu_long *)(a)))
+# define writel(a, b) (*((vu_long *)(b)) = __swap_32((vu_long)a))

readl() should be __swap_32() not __swap_16(). He has already committed a patch to fix it.

Besides that, usb works well.

Cheers!
Wei.

> -----Original Message-----
> From: Markus Klotzbücher [mailto:mk at denx.de] 
> Sent: Wednesday, June 06, 2007 6:53 PM
> To: Zhang Wei-r63237
> Cc: u-boot-users at lists.sourceforge.net; Loeliger 
> Jon-LOELIGER; Wang Haiying-r54964; wd at denx.de
> Subject: Re: [PATCH 2/3] Added USB PCI-OHCI chips 
> support,interrupt pipe support and usb event poll support.
> 
> Dear Zhang Wei,
> 
> "Zhang Wei-r63237" <Wei.Zhang at freescale.com> writes:
> 
> > How about your codes cleaning and this patch?
> 
> I finally made it, sorry it took so long. Can you test the 
> code with PCI
> OHCI? I guess you will have to update you board configuration (add
> CFG_OHCI_SWAP_REG_ACCESS).
> 
> Comments? Thanks!
> 
> Viele Grüße / Best regards
> 
> Markus Klotzbücher
> 
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
>