[U-Boot-Users] NAND patch update for KB9202B

[Wolfgang Denk]

In message <20070607205405.GD7048 at traven> you wrote:
> 
> this is an update of the NAND support patch for the KB9202 board,
> adapted to changes in the board specific Makefile

Sorry, but I have to reject this patch. Please see
http://www.denx.de/wiki/UBoot/Patches for help.

* Signed-off-by: line is missing.
* Patch is not inline, but compressed and thus unreadable
* Patch contains coding style violations (C++ comments)

Also, why are you doing this:

+#ifndef        CONFIG_KB9202B_ATL
+/* 
+       AT91C_BASE_PIOC->PIO_SODR = AT91C_PIO_PC28;
+       AT91C_BASE_PIOC->PIO_ODR = AT91C_PIO_PC29;
+       AT91C_BASE_PIOC->PIO_PER = AT91C_PIO_PC28 | AT91C_PIO_PC29;
+       AT91C_BASE_PIOC->PIO_OER = AT91C_PIO_PC28;
+*/ 
+       AT91C_BASE_PIOC->PIO_SODR = ((unsigned)1<<28);
+       AT91C_BASE_PIOC->PIO_ODR = ((unsigned)1<<29);
+       AT91C_BASE_PIOC->PIO_PER = ((unsigned)1<<28) |
((unsigned)1<<29);
+       AT91C_BASE_PIOC->PIO_OER = ((unsigned)1<<28);
+#else
+/* 
+       AT91C_BASE_PIOB->PIO_SODR = AT91C_PIO_PB26;
+       AT91C_BASE_PIOB->PIO_ODR = AT91C_PIO_PB27;
+       AT91C_BASE_PIOB->PIO_PER = AT91C_PIO_PB26 | AT91C_PIO_PB27;
+       AT91C_BASE_PIOB->PIO_OER = AT91C_PIO_PB26;
+*/ 
+       AT91C_BASE_PIOB->PIO_SODR = ((unsigned)1<<26);
+       AT91C_BASE_PIOB->PIO_ODR = ((unsigned)1<<27);
+       AT91C_BASE_PIOB->PIO_PER = ((unsigned)1<<26) |
((unsigned)1<<27);
+       AT91C_BASE_PIOB->PIO_OER = ((unsigned)1<<26);
+#endif 

If the commented out code is wrong, then it should be removed. On the
other hand, it looks better to me  than  the  code  that  is  inplace
instead. Please clean up.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
panic: can't find /