[U-Boot-Users] [PATCH: cmdcfg: 00/19] Introduce initial versions of new Command Config files.

[Wolfgang Denk]

In message <466EBA23.4030308 at freescale.com> you wrote:
>
> #ifdef CONFIG_CMD_AUTOSCRIPT
> #undef CONFIG_CMD_AUTOSCRIPT
> #define CONFIG_CMD_AUTOSCRIPT CONFIG_CMD_AUTOSCRIPT
> #else
> #define CONFIG_CMD_AUTOSCRIPT 0
> #endif


#define foo foo ??? Not that looks uterly strange to me...

> ... ( repeat for each CONFIG_CMD_x )

grrrghh....

> #define CONFIG_COMMANDS \
> 	(CONFIG_CMD_AUTOSCRIPT | \
> 	CONFIG_CMD_x (repeat for each CONFIG_CMD_x)

Did you actually test if this works?

> With this technique, you won't need to modify all of the source files that use 
> CONFIG_COMMANDS.

But we *do* want to modify all files to move them to using the new
scheme.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning there was nothing.
And the Lord said "Let There Be Light!"
And still there was nothing, but at least now you could see it.