[U-Boot-Users] [PATCH] Add Extricom's EXSW6000 board
Wolfgang Denk
wd at denx.de
Thu Jun 21 22:52:19 CEST 2007
In message <ffc2b1d40706202307g63173ef6gd0caf19696ed4566 at mail.gmail.com> you wrote:
> Signed-off-by: Eran Liberty
>
> Patch exceed 40K and there is no logic in splitting it up. here is
> link which is good for one week.
>
> http://download.yousendit.com/1E8803AE27CE724F
You patch has many coding styyle issues: indentation not by TABs,
trailing white space, excessive newlines, ...
Why are you adding compiler flags like -DCONFIG_EXSW6000=1 etc. to
the PLATFORM_CPPFLAGS? This should not be necessary as these #defines
are suppoosed tobe provided by your board config file. Please avoid
such reduncancy.
Please cleanup and resubmit. Note that the link should be valid not
only for a few days, otherwise chances are that we just lose it.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are some things worth dying for.
-- Kirk, "Errand of Mercy", stardate 3201.7
More information about the U-Boot
mailing list