[U-Boot-Users] U-boot ColdFire development

[Stefan Roese]

TsiChung,

On Thursday 21 June 2007, Liew Tsi Chung-r5aahp wrote:
> Here is the test version for 5329 u-boot source at Freescale.
> http://opensource.freescale.com/git?p=u-boot-coldfire.git;a=summary
>
> Added:
> board/freescale/M5329EVB/Makefile config.mk flash.c m5329evb.c and
> u-boot.lds

Are you sure that you need this board specific flash driver? Can't you use the 
common CFI flash driver? What FLASH chips are used on the board?

> cpu/mcf532x/Makefile config.mk cpu.c cpu_init.c speed.c 
> start.S

Do you think it is needed to create a new CPU directory for this ColdFire 
family? Or should we rename the old directory and try to merge the files 
together?

Are the differences that big between the ColdFire families? How much of the 
code is duplicated now?

> drivers/net/mcffec.c drivers/serial/mcfserial.c

Naming this driver mcfserial.c in the serial directory is somewhat redundant. 
Why not just call it mfc.c?
 
> include/asm-m68k/immap_5329.h m5329.h mcfrtc.h
> include/configs/M5329EVB.h lib_m68k/interrupts.c rtc/rtc.c
>
> Modified:
> Makefile
> MAKEALL

You changed the file modes of Makefile and MAKEALL. Please revert this change.

> README
> common/cmd_bdinfo.c cmd_mii.c
> include/asm-m68k/byteorder.h fec.h io.h mcftimer.h mcfuart.h ptrace.h
> u-boot.h lib_m68k/board.c time.c
>
> I had placed the mcfserial.c under drivers/serial and mcffec.c under
> drivers/net. The rtc.c is under rtc/.
>
> 1. I do have one more doubt about placing the following defines as we
> discussed early.
>
> > /* Timer */
> > #define CONFIG_MCFTMR
> > #ifdef CONFIG_MCFTMR
> > #	define CFG_UDELAY_BASE	(0xFC070000)
> > #	define CFG_TMR_BASE		(0xFC074000)
> > #	define CFG_INTR_BASE	(0xFC048000)
> > #	define CFG_TMRINTR_NO	(32)
> > #	define CFG_TMRINTR_MASK	(1)
> > #endif
>
> If I place the #ifdef CONFIG_MCFTMR ... #endif in say immap_5329.h,
> isn't that in time.c must include <asm/immap_5329.h>.
>
> Time.c
> #ifdef CONFIG_5329
> #include <asm/immap_5329.h>
> #endif
>
> #ifdef CONFIG_5272
> #include <asm/immap_5272.h>
> #endif
> ...
>
> Is there a way not to include <asm/immap_5xxx.h> in time.c each time a
> new processor is added?

How about introducing a new header which will do this CPU architecture include 
handling. Something like this:

include/asm-m68k/immap.h:

...
#ifdef CONFIG_5329
#include <asm/immap_5329.h>
#endif

#ifdef CONFIG_5272
#include <asm/immap_5272.h>
#endif
...

And also one for the general defines.

include/asm-m68k/mcf5xxx.h:

...
#ifdef CONFIG_5329
#include <asm/m5329.h>
#endif

#ifdef CONFIG_5272
#include <asm/m5272.h>
#endif
...

Then all files including those headers only need to include those "generic" 
headers.

What do you think?

> 2. I seperated the MII feature from fec.c and placed in under
> board/freescale/mxxxevb.c. Since the mii phy is board dependent not cpu
> dependent, do you agree?

Hmmm. Not sure. I have to admit that I am no expert in the ColdFire FEC and 
especially not regarding your eval board. But the MII code in mxxxevb.c 
doesn't look board specific to me. Why do you think it is board specific? And 
if it really is board specific then please move it into a separate file.

> 3. EHCI/OTG driver development. Do I need to modify the current
> cmd_usb.c to include EHCI or create a new file cmd_hsusb.c?

AFIK, there is no EHCI support in U-Boot right now. Do you really plan to 
support EHCI, or is your USB host controller also OHCI compatible?

Thanks again for your effort.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================