[U-Boot-Users] [PATCH] ppc4xx: Add pci_pre_init() for 405 boards

Stefan Roese sr at denx.de
Fri Jun 22 08:04:53 CEST 2007


On Thursday 21 June 2007, Wolfgang Denk wrote:
> > This patch adds support for calling a plattform dependant
> > pci_pre_init() function for 405 boards. This can be used to
> > move the current pci_405gp_fixup_irq() function into the
> > board code.
>
> I think we should  stop  using  this  method  to  provide  for  board
> specific code. Please use a weak function instead. See archive for
> earlier discussions of how to do that.

Yes, please.

Matthias just copied the already existing PPC440 example to the PPC405 code. 
But we should really stop extending the define mess right now. So Matthias, 
could you please implement this in the way Wolfgang descried? And if possible 
cleanup the 440 part too so that we can get rid of the CFG_PCI_PRE_INIT 
define completely?

Thanks.

Viele Grüße,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================




More information about the U-Boot mailing list