[U-Boot-Users] command loads broken since a while

Wolfgang Grandegger wg at grandegger.com
Fri Jun 22 15:05:56 CEST 2007


Hello,

recently, I realized that the U-Boot command "loads" is broken and the 
attached preliminary patch fixes it:

diff --git a/common/cmd_load.c b/common/cmd_load.c
index f63b8e8..2d9e0f0 100644
--- a/common/cmd_load.c
+++ b/common/cmd_load.c
@@ -240,12 +240,14 @@ read_record (char *buf, ulong len)
  			*p = c;
  		}

+#if 0
  	    /* Check for the console hangup (if any different from serial) */
  	    if (gd->jt[XF_getc] != getc) {
  		if (ctrlc()) {
  		    return (-1);
  		}
  	    }
+#endif
  	}

  	/* line too long - truncate */

The error sneaked in, when serial_getc was replaced with getc some time 
in the past. Can somebody tell me what the above code snippet is good 
for? I cannot see how to run the transfer over a line not being the 
console but maybe I have missed something.

Wolfgang.




More information about the U-Boot mailing list