[U-Boot-Users] [PATCH] ppc4xx: Remove sequoia/sequioa.h. Cleanup ppc440.h for PPC440EPX
Niklaus Giger
niklausgiger at gmx.ch
Wed Jun 27 10:52:01 CEST 2007
On Monday 25 June 2007 20:16:21 Stefan Roese wrote:
> Hi Niklaus,
>
> On Monday 25 June 2007, Niklaus Giger wrote:
> > The only lines which I exceed 80 characters are lines that my patch does
> > not touch or removes them. Is it my duty to fix all lines which are too
> > long in a source file? Or did I miss a line?
>
> I'm not talking about too long coding lines, but the line wrap most likely
> caused by your mail client. For example the sequoia.h file (even if removed)
> has some line wraps which case that the patch can't be applied clean.
>
> > Does the limit of 80 characters also apply to *.h-files? If yes, we have
> > about 485 lines to fix in include/ppc*.h.
>
> Normally the 80 characters line length also apply the the headers (all source
> code files). But you don't have to clean up existing code. Please just make
> sure that your mail client doesn't warp the lines upon sending.
>
> Hint: Please send the mail first to yourself and try to apply the patch to
> your repository. If this works without any problems you can send it to the
> list.
a) disabled automatic line wrapping in my kmail settings.
b) Finally tracked down the problem, that kmail changes the encoding from
"us-ascii" to "iso-8859-1" as soon as it sees a signature with a "ä" like in
Näfels. Then the lines with "---" get replaced by "=2d--" (as seen by vi).
Weird behaviour.
Resubmitted patch will follow
--
Niklaus Giger
Netstal Maschinen AG
CH-8752 Naefels
More information about the U-Boot
mailing list