[U-Boot-Users] [PATCH] Support for csb535fs / i.MX21 LiteKit.

[Wolfgang Denk]

In message <45E68A01.3060607 at aotek.es> you wrote:
> > I know that slightly modified duplicate code is common in u-boot, so
> > this is not an critique on your work, but I'd really like to move away
> > from this mode of operation.  Duplicating the original file and
> > modifying it is certainly the easiest way to add support for a new
> 
> And It makes the code more readable. It's the pro.

No, it doesn't make anything more redable. Distributing the code over
too many polaces just pollutes the source tree.

> > 10 times and a bug is found in it at a later date; the bug fix needs
> > to be applied to 10 files, not one.
> 
> Yes, It's the con. But, how many times does it happen?.

All too many times.

> Ummm, lib_arm/imx?. I think this mixes up concepts.
> Why not to decouple the arm cores and the SoC code?. For example:
>           cpu/arm/cores/arm926ejs 
>           cpu/arm/soc/imx

No, but eventually cpu/arm/imx_common plus cpu/arm926ejs


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I used to be indecisive, now I'm not sure.