[U-Boot-Users] [PATCH] Add option -p to mkimage to align an image to word boundary

Wolfgang Denk wd at denx.de
Fri Mar 2 16:10:06 CET 2007

In message <OFD9437230.22326F6B-ONC1257292.00465732-C1257292.0047638F at philips.com> you wrote:
> * Add option -p to mkimage for always alligning an image to word boundary.

Images are already aligned. They have a 64 byte header prepended.

> This patch adds a feature to tools/mkimage.c by making it possible to 
> always align a filesystem image to word boundary. Images created with this 
> option are always aligned on word boundary and will always correctly be 
> loaded with the ARM RVDS when using raw mode (Raw data one word per word 

I don't get what you're trying to tell.

Looking at your  patch,  it  seems  you're  confusing  padding  to  a
multiuple  of 32 bit words with alignment - note these are completely
different things.

> of memory). Images created without this option will not boot with u-boot 
> and abort with "Data CRC error". This situation has been reported several 
> times on this maillinglist.

Has it? I have never seen it. Do you have a reference?

> It is tested against todays git repository.

You patch is not acceptable; the description is wrong both in the log
and in the help message, it has coding style violations  (indentation
not by TAB etc.) and spelling errors.

Also, I'm not sure if this is really a mkimage problem.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Conquest is easy. Control is not.
	-- Kirk, "Mirror, Mirror", stardate unknown

More information about the U-Boot mailing list