[U-Boot-Users] [GIT-PULL][Blackfin] Please pull http://www.denx.de/git/u-boot-blackfin.git

[Wolfgang Denk]

Dear Aubrey,

in message <27d85ee10703082203m74822868i5d3fe6fd0eaa269a at mail.gmail.com> you wrote:
> The following changes since commit eb92f613556800f7483666db09d9a237ad911d4a:
> 
> Aubrey.Li (2)
>     [Patch 1/2] Remove obsolete blackfin port and add bf533 platform support

Sorry, but I have to reject to merge the current version.



Commit 3f0606ad0b5639f7f22848fe5b4574e754d0470f breaks building in
other directories, i.e. changes like this one are bad and need to be
fixed:

board/bf533-ezkit/Makefile:


-LIB	= $(obj)lib$(BOARD).a
+LIB	= lib$(BOARD).a
...
-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
-OBJS	:= $(addprefix $(obj),$(COBJS))
-SOBJS	:= $(addprefix $(obj),$(SOBJS))
+$(LIB):	.depend $(OBJS) u-boot.lds
+	$(AR) cr $@ $(OBJS)

-$(LIB):	$(obj).depend $(OBJS)
-	$(AR) $(ARFLAGS) $@ $(OBJS)
+u-boot.lds: u-boot.lds.S
+	$(CPP) $(CPPFLAGS) -P -Ubfin $^ > $@.tmp
+	mv -f $@.tmp $@

etc.

The same is happens in other Makefiles.


Also, turning back Copyright entries is a Bad Thing, too.


Also, there is a LOT of Coding Style problems:

C++ comments in ./include/asm-blackfin/arch-bf533/defBF532.h,
./include/asm-blackfin/arch-common/cdef_LPBlackfin.h,
./include/configs/bf533-ezkit.h, ./include/configs/bf533-stamp.h

Trailing white space in ./cpu/bf533/bf533_serial.h,
./cpu/bf533/cache.S, ./cpu/bf533/flush.S, ./cpu/bf533/init_sdram.S,
./cpu/bf533/init_sdram_bootrom_initblock.S, ./cpu/bf533/interrupt.S,
./cpu/bf533/start.S, ./cpu/bf533/traps.c, ./cpu/bf533/video.c

Indentation not by TABs at least in
./cpu/bf533/init_sdram_bootrom_initblock.S, ./cpu/bf533/start.S,
,./include/asm-blackfin/arch-bf533/anomaly.h
./include/asm-blackfin/mem_init.h, ./include/configs/bf533-ezkit.h,
./include/configs/bf533-stamp.h

Too many empty lines in ./lib_blackfin/memcpy.S

Trailing empty lines in ./board/bf533-ezkit/u-boot.lds.S,
./board/bf533-stamp/u-boot.lds.S, ./cpu/bf533/init_sdram.S,
./cpu/bf533/init_sdram_bootrom_initblock.S


As a custodian you are supposed to take special care to clean all
these things up before sending a pull request!


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When you die, the first thing you lose is your life. The  next  thing
is the illusions.                       - Terry Pratchett, _Pyramids_