[U-Boot-Users] [GIT-PULL][Blackfin] Please pull http://www.denx.de/git/u-boot-blackfin.git

[Wolfgang Denk]

In message <27d85ee10703092115g57e843b9o5d60ce6938d76b03 at mail.gmail.com> you wrote:
>
> > -LIB    = $(obj)lib$(BOARD).a
> > +LIB    = lib$(BOARD).a
> > ...
> > -SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
> > -OBJS   := $(addprefix $(obj),$(COBJS))
> > -SOBJS  := $(addprefix $(obj),$(SOBJS))
> > +$(LIB):        .depend $(OBJS) u-boot.lds
> > +       $(AR) cr $@ $(OBJS)
> >
> > -$(LIB):        $(obj).depend $(OBJS)
> > -       $(AR) $(ARFLAGS) $@ $(OBJS)
> > +u-boot.lds: u-boot.lds.S
> > +       $(CPP) $(CPPFLAGS) -P -Ubfin $^ > $@.tmp
> > +       mv -f $@.tmp $@
> >
> > etc.
> >
> > The same is happens in other Makefiles.
> 
> u-boot.lds assumes the virtual memory address(VMA) of u-boot is the
> same as load memory address(LMA), which is not fit for blackfin.

You completely miss the point. I'm talking about all the "$(obj)"
stuff you removed with your patch.

> > Commit 3f0606ad0b5639f7f22848fe5b4574e754d0470f breaks building in
> > other directories
> 
> Sorry, I don't understand. Where should I test building u-boot?

Try running "make O=some_other_dir" or
"BUILDDIR=some_other_dir ./MAKEALL arm"
and then check, if (1) it works and (2) files have been created in
your local dir.

> Wired, c files and h files was formatted by the kernel script Lindent,
> and when I use quilt to maintain these patches, quilt doesn't warn me
> anymore. How do you check the coding style issues? and is there any

vi ...

> script can help to format assemble files?

None that I know.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Don't think; let the machine do it for you!"        - E. C. Berkeley