[U-Boot-Users] SATA PATCH

Wolfgang Denk wd at denx.de
Wed Mar 14 21:31:29 CET 2007

Dear Mushtaq,

in message <45F7F19A.9030605 at procsys.com> you wrote:
> Resending the SATA patch with size less than 40kb.

Thanks. The patch has a few coding style issues: indentation by space
instead of TABs, trailing white space, etc.

Please see http://www.denx.de/wiki/UBoot/CodingStyle

Please insert a few more spaces, i. e. instead of 

	}else if(strcmp(argv[1],"part") == 0){
	} else if (strcmp(argv[1],"part") == 0) {

In a few places your indentation looks random, like here:

	printf ("%ld blocks written: %s\n",
	                                        n, (n==cnt) ? "OK" : "ERROR");

Please use only lower case letters for the command name, i. e. "sata"
instead of "Sata".

In common/Makefile and drivers/Makefile,  please  keep  the  list  of
object file names alphabetically sorted.

Please clean up and resubmit.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'd like to meet the man who invented sex and see what  he's  working
on now.

More information about the U-Boot mailing list