[U-Boot-Users] [PATCH] Fix wrong ID for 28F256P30 in flash.h

[Tolunay Orkun]

Pete MacKay wrote:
> Intel was inconsistent in their device IDs for the P30 Strata NOR.  The
> header flash.h has incorrect device IDs for the top- and bottom-mapped
> versions of the 32 MB chips as a result.  It's an easy mistake to make...
>
> --- u-boot.git/include/flash.h	2007-03-12 13:40:31.000000000 -0700
> +++ u-boot/include/flash.h	2007-03-12 19:26:25.000000000 -0700
> @@ -290,8 +290,8 @@
>  #define INTEL_ID_28F64P30B  0x881A881A	/*  64M =  32K x 255 + 32k x 4 */
>  #define INTEL_ID_28F128P30T 0x88188818	/* 128M =  64K x 255 + 32k x 4 */
>  #define INTEL_ID_28F128P30B 0x881B881B	/* 128M =  64K x 255 + 32k x 4 */
> -#define INTEL_ID_28F256P30T 0x88198819	/* 256M = 128K x 255 + 32k x 4 */
> -#define INTEL_ID_28F256P30B 0x881C881C	/* 256M = 128K x 255 + 32k x 4 */
> +#define INTEL_ID_28F256P30T 0x89198919	/* 256M = 128K x 255 + 32k x 4 */
> +#define INTEL_ID_28F256P30B 0x891C891C	/* 256M = 128K x 255 + 32k x 4 */
>  
>  #define INTEL_ID_28F160S3   0x00D000D0	/*  16M = 512K x  32 (64kB x 32)	*/
>  #define INTEL_ID_28F320S3   0x00D400D4	/*  32M = 512K x  64 (64kB x 64)	*/
>
>
>   

Thanks for the update. However, the CFI driver actually does not use 
these macro.

Is there a place (custom driver) that this ID was used an caused a problem?

I personally actually want to remove these macros for any device that 
could be serviced by cfi_flash.c driver.

Tolunay