[U-Boot-Users] [PATCH] Fix the condition to detect if an image is already in its place

[Wolfgang Denk]

In message <20070316090213.GA4940 at informatik.uni-freiburg.de> you wrote:
> 
> > XIP = eXecute In Place, i. e. the image is run directly from flash /
> > ROM, without loading it to RAM at all.
> That's clear, yes.  I recognize that my example is notional.  But the
> other way round makes more sense.  If you have a non-XIP image then it
> is not moved if it was loaded to ih_load or (ih_load - 0x40).

If you have a non-XIP image you willnot execute that part of the code.
It was in an if-branch ...

> Would you think the fix being correct if that xip patch were not relying
> on that behaviour?  If so, not taking the patch because of this IMHO is
> a poor policy.

Your "fix" was made to a XIP specific part of the code, where it
breaks existing code.

For non-XIP images I don't see a problem - that works well on all
architectures.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's all Klatchian to me.
        - Terry Pratchett & Stephen Briggs, _The Discworld Companion_