[U-Boot-Users] [patch] Fix clock calculation for S3C2410 cpu

Wolfgang Denk wd at denx.de
Thu Mar 22 23:49:04 CET 2007


In message <47F3F98010FF784EBEE6526EAAB078D1024F84A6 at tq-mailsrv.tq-net.de> you wrote:
> 
> The S3C2410 cpu has a new bit in the CLKDIV register, which is now interpreted
> correctly (for a clock ratio of 1:4:4).
...
> +#ifdef CONFIG_S3C2410
> +    if (clk_power->CLKDIVN & 0x4)
> +	    return get_FCLK()/4;
> +    else
> +#endif
>      return((clk_power->CLKDIVN & 0x2) ? get_FCLK()/2 : get_FCLK());

Please omit the dispensable "else".

> +#ifdef CONFIG_S3C2410
> +    if (clk_power->CLKDIVN & 0x4)
> +	    return get_FCLK()/4;
> +    else
> +#endif
>      return((clk_power->CLKDIVN & 0x1) ? get_HCLK()/2 : get_HCLK());

ditto.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"And they told us, what they wanted... Was a sound  that  could  kill
some-one, from a distance."                               - Kate Bush




More information about the U-Boot mailing list