[U-Boot-Users] PATCH] Add 8641reset commmand for mpc8641hpcn board
wd at denx.de
Sun Mar 25 22:23:56 CEST 2007
in message <1174661567.32390.63.camel at ld0161-tx32> you wrote:
> But the overall approach? Is it better than the
> previous version that hit common code?
Anything that stays local is better ... at least a bit.
> > Also, I object against the command name. It should follow standard
> > name rules (enven though these are not strictly enforced by the
> > current command line parser), i. e. only consist of alphanumeric
> > characters and underscores, and begin with an underscore or an
> > alphabetic character (and I hereby discourage to use an underscore as
> > the first character).
> OK. Will "reset8641" be acceptable?
Yes, as far as the name goes.
Conceptually I disagree. This command implements two different
functions: (1) it adjusts some system parameters (but this change
will only take affect after a reboot), and (2) it performs a reboot.
Following good old Unix design, you should split this command into
it's logical parts. Then you will probably realize that the second
part (perform a reset) already exists and can be reused instead of
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am more bored than you could ever possibly be. Go back to work.
More information about the U-Boot