[U-Boot-Users] XUPV2P support

Wolfgang Denk wd at denx.de
Mon Mar 26 09:08:04 CEST 2007


In message <3278.5970-14656-461775676-1174888427 at seznam.cz> you wrote:
> 
> diff file is in attachment. 
> 
> Changes: 
> Support for XUPV2P board 
> BSP autoconfig support 

You modify Copyright entries, and  I  don't  see  any  Signed-off-by:
line.  Are  you  sure  you  can / should do that? Some files contain,
after your changes applied, no license header at  all.  This  is  not
acceptable.  It  must  be  clear  they  come  under  a GPL compatible
license.

You mix Xilinx and Microblaze related changes in one patch. This is
not acceptable. Please split up.

Please read http://www.denx.de/wiki/UBoot/Patches ; then clean up and
resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If God had a beard, he'd be a UNIX programmer.




More information about the U-Boot mailing list