[U-Boot-Users] New port Siemens SMN42 board

[Wolfgang Denk]

In message <200703261750.l2QHosEa002639 at peedub.jennejohn.org> you wrote:
>
> I was sort of unsure about this myself. I asked Wolfgang Denk whether I
> shouldn't also use CONFIG_LPC2292 here, but he never responded to my
> question. I'm not certain whether this will adversely impact other boards.

I don't know a good answer.

> I'm willing to change the patch so that it reads (CONFIG_MMC && \
> CONFIG_LPC2292), which would minimize its scope.
> 
> On a (ARM) related note - our customer reports that he cannot compile u-boot
> because his tool-chain dumps its cookies on this union in include/ \
> asm-arm/processor.h:
> 
> union debug_insn {
> 	u32	arm;
> 	u16	thumb;
> };

"arm" is a perfectly legal name for a C variable.

> His gcc defines arm as 1 which leads to big problems. He's unwilling to
> move to a different tool-chain (what can one do?).
> 
> AFAICT the union is not used anywhere in the C-sources, either directly or
> indirectly. In fact most of this header file seems to be excess baggage
> taken directly from the linux-tree. Any problem with renaming the arm entry
> to e.g. _arm?

I want to keep this file as close as possible to the  original  Linux
header  file.  Even  the  current  kernel.org  tree has "u32 arm;" in
"include/asm-arm/processor.h", so please don't change it.



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office:  Kirchenstr. 5,       D-82194 Groebenzell,            Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He'd been wrong, there _was_ a light at the end of the tunnel, and it
was a flamethrower.                         - Terry Pratchett, _Mort_