[U-Boot-Users] [PATCH v3] Fix initrd length miscalculation in bootm command when using a dtu

Wolfgang Denk wd at denx.de
Fri May 4 18:27:10 CEST 2007


In message <463B3463.1030702 at freescale.com> you wrote:
> 
> If you apply my patch, then the comment becomes correct.  My goal was to 
> lock the variables 'len' and 'data' into one purpose.  The reason the 

I think you actually missed a few places where len was also used.

> bug existed is because the other developer didn't realize this.  He used 
> 'len' thinking it was available.  In a sense, I was trying to implement 

This type of thinking  was  plain  wrong.  You  must  never  use  any
variable without understanding what it's being used for.

> Stefan said he had a testing repo of some kind.  How about we just use 
> that?  If Stefan is willing, he can apply my emailed patches to his repo.

The u-boot-testing repo is actually *my* guardian repo where I put all
stuff in that does not fit anywhere else.

As I explained before, you need a  normal  developer's  repo,  not  a
guardian  one.  And I repeat: I offer you such a repo, it's available
right now, I just need the IP address from where you will connect.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,    CEO: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Cogito cogito ergo cogito sum - "I think that I  think,  therefore  I
think that I am."          - Ambrose Bierce, "The Devil's Dictionary"




More information about the U-Boot mailing list