[U-Boot-Users] [PATCH] Fix Marvell 88e1145 PHY init code

Andy Fleming afleming at freescale.com
Wed May 9 21:11:43 CEST 2007


Fix a bug in the Marvell 88e1145 PHY init code in the TSEC driver
where the reset was being done after the errata code instead of
before.

Signed-off-by: Haiying Wang <haiying.wang at freescale.com>
Signed-off-by: Andy Fleming <afleming at freescale.com>
---
This one was sent to me a bit ago, but I lost it.  It's going in unless 
there are objections.  And again, sorry for the space/tab thing

 drivers/tsec.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/tsec.c b/drivers/tsec.c
index b418773..693328d 100644
--- a/drivers/tsec.c
+++ b/drivers/tsec.c
@@ -1012,14 +1012,16 @@ static struct phy_info phy_info_M88E1145 = {
 	"Marvell 88E1145",
 	4,
 	(struct phy_cmd[]){	/* config */
+			   /* Reset the PHY */
+			   {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+
 			   /* Errata E0, E1 */
 			   {29, 0x001b, NULL},
 			   {30, 0x418f, NULL},
 			   {29, 0x0016, NULL},
 			   {30, 0xa2da, NULL},
 
-			   /* Reset and configure the PHY */
-			   {MIIM_CONTROL, MIIM_CONTROL_RESET, NULL},
+			   /* Configure the PHY */
 			   {MIIM_GBIT_CONTROL, MIIM_GBIT_CONTROL_INIT, NULL},
 			   {MIIM_ANAR, MIIM_ANAR_INIT, NULL},
 			   {MIIM_88E1011_PHY_SCR, MIIM_88E1011_PHY_MDI_X_AUTO,
-- 
1.5.0.2.230.gfbe3d-dirty





More information about the U-Boot mailing list