[U-Boot-Users] Non-Board specific patches - how to handle? Was: [PATCH] MACOSX support

Robin Getz rgetz at blackfin.uclinux.org
Sat May 12 00:04:30 CEST 2007


On Fri 20 Apr 2007 12:20, Aubrey Li pondered:
> The following patch fixes compilation issue on macosx
>
> Singed-off-by: Marc Hoffman <Marc.Hoffman at analog.com>
> Signed-off-by: Aubrey Li <aubrey.adi at gmail.com>
> ---
>  tools/mkimage.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/mkimage.c b/tools/mkimage.c
> index 416e658..2125130 100644
> --- a/tools/mkimage.c
> +++ b/tools/mkimage.c
> @@ -446,7 +446,7 @@ NXTARG:		;
>  	}
>
>  	/* We're a bit of paranoid */
> -#if defined(_POSIX_SYNCHRONIZED_IO) && !defined(__sun__) &&
> !defined(__FreeBSD__)
> +#if defined(_POSIX_SYNCHRONIZED_IO) && !defined(__sun__) &&
> !defined(__FreeBSD__) && !defined(__APPLE__)
>  	(void) fdatasync (ifd);
>  #else
>  	(void) fsync (ifd);
> @@ -496,7 +496,7 @@ NXTARG:		;
>  	(void) munmap((void *)ptr, sbuf.st_size);
>
>  	/* We're a bit of paranoid */
> -#if defined(_POSIX_SYNCHRONIZED_IO) && !defined(__sun__) &&
> !defined(__FreeBSD__)
> +#if defined(_POSIX_SYNCHRONIZED_IO) && !defined(__sun__) &&
> !defined(__FreeBSD__) && !defined(__APPLE__)
>  	(void) fdatasync (ifd);
>  #else
>  	(void) fsync (ifd);

Wolfgang:

How would you like to handle patches like this?

Should an arch maintainer put it in their git tree, and push you the change - 
(even though it is common code) or is a patch to the mailing list the best 
way to handle?

Thanks.




More information about the U-Boot mailing list