[U-Boot-Users] [PATCH u-boot-fdt] FDT command improvements.

Wolfgang Denk wd at denx.de
Sun May 13 02:05:32 CEST 2007

In message <46465158.5070602 at gmail.com> you wrote:
> > The limit on the length of lines is 80 columns and THIS IS A HARD
> > LIMIT.
> Does :set ts=4 count?  It fits in 80 columns then. ;-)

No, this does not count, as it violates another part of the Coding
Style document:

"Tabs are 8 characters, and thus indentations are also 8 characters.
There are heretic movements that try to make indentations 4 (or even 2!)
characters deep, and that is akin to trying to define the value of PI to
be 3."

> The nesting is getting me in trouble.  I can fix some, but some would be 
> ugly to fix because I would need to split strings.  I could move the 
> value parsing into a subroutine, that would help.

"... The answer to that is that if you need
more than 3 levels of indentation, you're screwed anyway, and should fix
your program.

In short, 8-char indents make things easier to read, and have the added
benefit of warning you when you're nesting your functions too deep.
Heed that warning."

> Since the LIMIT IS HARD, I'll work it...


Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,    CEO: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Speed of a tortoise breaking the sound barrier         = 1 Machturtle

More information about the U-Boot mailing list