[U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT

[Timur Tabi]

Nikita V. Youshchenko wrote:
> Current include/configs/MPC8349ITX.h does contain some support for building
> image that will be started from memory (without putting in into flash).
> It could be triggered by building with TEXT_BASE set to a low value.

Well that's ironic.  I was just about to remove support for ramboot altogether from all 
8xxx boards.

I guess I won't be doing that.  However, I have to NACK your patch for one reason:

> -#define CONFIG_COMMANDS                (CONFIG_CMD_DFL | \
> +#ifdef CFG_NO_FLASH
> +#define CONFIG_COMMANDS_DEFAULT (CONFIG_CMD_DFL & ~(CFG_CMD_FLASH | \
> +                                                   CFG_CMD_IMLS))
> +#else
> +#define CONFIG_COMMANDS_DEFAULT CONFIG_CMD_DFL
> +#endif

Please don't put CONFIG_COMMANDS inside an #ifdef block.  Instead, please follow the 
example of CONFIG_COMMANDS_CF.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale