[U-Boot-Users] [PATCH] fix compilation problem for mpc8349itx CFG_RAMBOOT

Wolfgang Denk wd at denx.de
Wed May 23 21:51:38 CEST 2007

In message <46548B5B.4060607 at freescale.com> you wrote:
> > This is extremely inconsistent. Some CONFIG_COMMANDS_* (PCI, I2C) are
> > used to add features, while others (FLASH) are used to remove
> > features. I consinder this very error prone.
> Well, it's supposed to be an alternative to what Nikita was proposing.  I wanted to keep 

It's bad. Use something like __CMD_ADD_I2C or  __CMD_REMOVE_FLASH  or
so, but don't use the same name for different functions.

> Please take a look at my MPC8349ITX.h to see the full extent of what I was trying to do. 

Yes, I know what it does. Frankly, it's ugly.

> Should they be renamed to CFG_COMMANDS_xxx?

No, as  CFG  also  has  a  specific  meaning.  Here,  you  just  need
temporary,  local  variables.  Please avoid name space pollution. You
can and should even #undef those after use.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Committee, n.:  A group of men who individually can do nothing but as
a group decide that nothing can be done.                 - Fred Allen

More information about the U-Boot mailing list