[U-Boot-Users] Imminent u-boot-fdt pull request
Jerry Van Baren
gerald.vanbaren at smiths-aerospace.com
Fri May 25 18:28:19 CEST 2007
Kim Phillips wrote:
> On Fri, 25 May 2007 07:54:47 -0400
> Jerry Van Baren <gerald.vanbaren at smiths-aerospace.com> wrote:
>
>> Thanks for the feedback, I'll check things. Pointers to files (and
>> lines) would be helpful. :-/
>>
>> WRT line lengths, Wolfgang dinged me on them so I created a cleanup
>> patch. As a result, one patch has line length violations and a later
>> patch fixes them. This may be related to your line length and multiple
>> copy comment.
>>
>> Thanks,
>> gvb
>
> $ wc -L common/fdt_support.c
> 139 common/fdt_support.c
>
> introduced by:
>
> commit 792f0989bf90961ba2644ccc718cf09d338706b8
> Author: Gerald Van Baren <vanbaren at cideas.com>
> Date: Wed May 16 22:39:59 2007 -0400
>
> Fix cmd_fdt line lengths, refactor code.
>
> Break lines that were greater than 80 characters in length.
> Move the fdt print and property parsing code to separate static functions
> to reduce coding clutter in the fdt_cmd handling body.
>
> Signed-off-by: Gerald Van Baren <vanbaren at cideas.com>
>
> Kim
Hmm, looks like I did a half-a$$ job there. Looking at the patch, I
only cleaned up cmd_fdt and missed cleaning up the long lines in
fdt_+support.c.
Sorry for the sloppiness, I'll fix that.
Best regards,
gvb
More information about the U-Boot
mailing list