[U-Boot-Users] [PATCH] LOGO: Adds LCD color map 565 support.

[Wolfgang Denk]

In message <20070525162154.GK21180 at enneenne.com> you wrote:
>
> > > +- CFG_LOGO_CMAP_MODE
> > > +		Define the current LCD color map mode. Default value is 444 but
> > > +		565 can also be used.
> > > +
> > 
> > Is the color map code really only relevant for the  logo  display?  I
> > tend to believe thatit has an overall effect and will - for example -
> > have impact on other bitmap files, too ?
> 
> This modification affects only function bitmap_plot() which is called
> by lcd_logo() only if CONFIG_LCD_LOGO is defined.

What about lcd_display_bitmap() and the color map it uses?

Why do we have two functions lcd_display_bitmap() and  bitmap_plot(*)
in  the  first  place? I feel both do very similar things? Maybe only
one function is needed?

[Please negotiate this also with Wolfgang Grandegger!]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't have to protect the environment -- the Second Coming is  at
hand."                                                   - James Watt