[U-Boot-Users] Imminent u-boot-fdt pull request
Jerry Van Baren
gerald.vanbaren at smiths-aerospace.com
Fri May 25 20:31:11 CEST 2007
Scott Wood wrote:
> Jerry Van Baren wrote:
>>> What about doing a search for device_type = "cpu", rather than
>>> looking for a specific CPU name? The Linux bootwrapper does it this
>>> way. It also has the benefit of working when there's more than one CPU.
>>>
>>> -Scott
>>
>>
>> I deeply regret the confusion I caused by pushing the "Send" when I
>> meant to push "Write" to start a new, unrelated, message. My updated
>> re-send, as you probably have figured out by now, is more coherent.
>>
>> OF_CPU is defined in the board-specific header file, e.g.
>> configs/MPC8360EMDS.h, pulled in by config.h. Since I am missing the
>> #include <config.h> in the two files being discussed, OF_CPU is
>> undefined and the string concatenation trick makes it silently disappear.
>
> Sure... I was just suggesting a more robust method, that doesn't rely on
> the board config file to define the CPU name.
>
> -Scott
Ah, now I follow. That is worth considering. That would make some
assumptions too, just different ones.
Of the top of my head...
* All CPUs are clocked the same (unlikely to be a problem)
* That the CPU actually _needs_ the fixups (currently they all get the
fixup so it isn't currently a problem)
As long as it works for the bootwrapper, it would work for u-boot. The
two are imperfect subsets of each other, however.
Thanks,
gvb
More information about the U-Boot
mailing list