[U-Boot-Users] Need the lists opinion on the "right" way to fix something (long)

[Grant Likely]

On 11/1/07, Wolfgang Denk <wd at denx.de> wrote:
> In message <OF35EFB6C6.4311E888-ON88257386.007BCD10-88257386.007E0B81 at selinc.com> you wrote:
> >
> > Since I've only been working with u-boot/open source for about 9 months,
> > I'm not really sure what the design philosophies are and what the
> > acceptable and/or "righ" way of fixing this would be.  Any input or
> > direction would be greatly appreciated.  Thanks.
>
> The simple rule is: whenever you use a variable / macro you must make
> sure it is defined. You use CFG_XILINX_SPARTAN3 in your board config,
> so you must make sure to include all needed header files there.

Also, the whole CFG_FPGA bitmask is a bad approach and should be
removed.  Instead the config should be based on whether or not the
CFG_XILINX_SPARTAN et al are defined or not.  CONFIG_CMD used to be
done with a bit field too, but it was removed due to it being
difficult to extend.

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195