[U-Boot-Users] [PATCH] TQM5200B: update MTD partition layout

[Wolfgang Denk]

In message <20071107141109.6486.18579.stgit at tq-sewsrv-4.tq-net.de> you wrote:
> - insert partition for dtb blob to TQM5200B MTD layout
> - fix MTD layout for highboot configuration
> - set env variables dependent on the configured board
>   (TQM5200 or TQM5200B)
> 
> Signed-off-by: Martin Krause <martin.krause at tqs.de>

I'm afraid I have to NAK this patch.

>  #  else	/* highboot */
> -#   define MTDPARTS_DEFAULT	"mtdparts=TQM5200-0:2560k(kernel),"	\
> +#   define MTDPARTS_DEFAULT	"mtdparts=TQM5200-0:256k(dtb);"		\
> +						"768k(environment),"	\
> +						"1536k(kernel),"	\

First, it is a realy ugly design to have the environment right in the
middle of your flash. Please locate it adjacent to the  U-Boot  code.
Ditto for the DTB.

Second, and major reason for my NAK: 1.5 MB is  much  too  small  for
current  2.6  Linux  kernels,  assuming  you  have  to  enable  a few
additional drivers. There was a good reason why I changed  this  size
recently.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Veni, Vidi, VISA:
        I came, I saw, I did a little shopping.