[U-Boot-Users] xilinx FPGA code

Andrew Dyer amdyer at gmail.com
Mon Nov 12 19:27:46 CET 2007


A couple of "IMHO" comments about this code in no particular order:

Is there any reason to have spartan2.c, virtex2.c and spartan3.c? They
are pretty much copies of each other with search and replace.

local PRINTF should be replaced with the global 'debug' macro.

this issue behind this patch should be addressed (relocating null pointers)
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/22918

I believe the edict was given by wd@ that CFG_HZ was always to be
1000, and delays can be spec'd in units of ms rather than based off of
CFG_HZ

could do with some whitespace cleanup & reformatting to 80 cols.

-- 
Hardware, n.:
        The parts of a computer system that can be kicked.




More information about the U-Boot mailing list