[U-Boot-Users] [PATCH] fdt: add common memory fixup function

Kim Phillips kim.phillips at freescale.com
Tue Nov 27 17:39:02 CET 2007


On Tue, 27 Nov 2007 08:13:07 -0600
Kumar Gala <galak at kernel.crashing.org> wrote:

> >> Was thinking about this some more and realized I don't like
> >> fdt_memory() getting called via bootm w/o the board code have  
> >> control.
> >>
> >> I think Kim suggest we have a CONFIG_OF_MEMORY_FIXUP that this call  
> >> is
> >> wrapped around.  But leave fdt_memory() available.  I want it such
> >> that the board code/config is in control of what fixups gets called
> >> for it.
> >
> > That's funny. My first patch wrapped the fixup in  
> > CONFIG_OF_MEMORY_FIXUP
> > and it was you, who suggested to drop this ;-). AFAIR Kim suggested to
> > wrap it in the existing OF_LIBFDT instead - what I did then. But I
> > have no objections, if you put CONFIG_OF_MEMORY_FIXUP in place again.
> 
> Yeah, I know.  I realized later that we should leave it to board code  
> to decide what it wants in such cases.  The reason for that is if you  
> can envision having multiple device trees in multiprocessor system  
> with each processor running a different OS.

so make it a weak fn then?

Kim




More information about the U-Boot mailing list