[U-Boot-Users] [PATCH]: tools: fix fw_printenv tool to compile again

[Markus Klotzbücher]

Hi Ben,

Ben Warren <bwarren at qstreams.com> writes:

> Markus Klotzbücher wrote:
>> How about the following:
>>
>> This patch updates the fw_printenv/fw_setenv userspace tool to include
>> the correct MTD header in order to compile against current kernel
>> headers. Backward compatibility is preserved by introducing an option
>> MTD_VERSION which can be set to "old" for compilation using the old MTD
>> headers. Along with this a number of warnings are fixed.
>>
> Sounds good to me.  It'd be cooler if make could detect the
> presence/absence of <linux/mtd-user.h>, but I'm not enough of a build
> system whiz to know how to do that.

I'm afraid nor am I. Suggestions welcome.

> A couple of additional requests:
>
> 1.  Can you also please add the other part of my patch that
> creates/destroys the 'fw_setenv' symbolic link?  It's a bit annoying
> that the documentation mentions the 'fw_setenv' utility, but it
> doesn't really exist without a bit of help.

Agreed that this confusing, but does a symbolic link really help?
Wouldn't it be better to simply describe the rationale in the
documentation instead?

> 2.  Please include changes to the relevant documentation (README +
> wiki) so that people know to when and how to set MTD_VERSION.  This
> may prevent a few 'RTFM' e-mails.

The patch I posted updates the README in tools/env/ and I'll update the
wiki as soon as the patch is accepted. I wonder though, if the
env/tools/README shouldn't be move into the main README. It's rather
hidden where it is right now.

Viele Grüße / Best regards

Markus Klotzbücher

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de