[U-Boot-Users] [PATCH] NET: Proper return code handling in eth_init() function in file eth.c

[Stefan Roese]

On Thursday 29 November 2007, Upakul Barkakaty wrote:
> NET: Proper return code handling in eth_init() function in file eth.c
>
> This patch modifies the return code handling in the eth_init()
> function, to be compatible with the handling of the return codes in
> the other network stack files. It now returns a 0 on Success and -1 on
> error.
>
> Signed-off-by: Upakul Barkakaty <upakul.barkakaty at conexant.com>
>
> diff -Naur a/net/eth.c b/net/eth.c
> --- a/net/eth.c	2007-11-26 09:53:55.000000000 +0530
> +++ b/net/eth.c	2007-11-26 10:55:59.000000000 +0530
> @@ -404,23 +404,23 @@
>  	struct eth_device* old_current;
>
>  	if (!eth_current)
> -		return 0;
> +		return -1;
>
>  	old_current = eth_current;
>  	do {
>  		debug ("Trying %s\n", eth_current->name);
>
> -		if (eth_current->init(eth_current, bis)) {
> +		if (!eth_current->init(eth_current,bis))
> +		{

Don't move the "{" into the next line.

Please change this and resend the patch. Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================