[U-Boot-Users] [PATCH 2/2] changes for IDS8247 board support

Wolfgang Denk wd at denx.de
Wed Oct 17 09:51:13 CEST 2007


In message <1192605199.3174.18.camel at p60635-ste.ids.de> you wrote:
> To get the IDS8247 board working following are done:
>  - FCC2 is deactivated
>  - FCC1 is activated
>  - I2C is activated
>  - CFI driver is activated
>  - Adapted for use with LIBFDT
> 
> Signed-off-by: Sergej Stepanov <Sergej.Stepanov at ids.de>
> --
...
> --- a/include/configs/IDS8247.h
> +++ b/include/configs/IDS8247.h
> @@ -19,6 +19,15 @@
...
> + *
> + * For IDS8247 platform
> + *  - FCC1 is activated
> + *  - FCC2 is deactivated 
> + *  - I2C is activated
> + *  - CFI driver is activated
> + *  - adopted for using with CONFIG_OF_LIBFDT
> + * Sergej Stepanov, IDS GmbH, Germany, <Sergej.Stepanov at ids.de>

Please omit such change logs from the files. We have the git history
for that - it makes little sense to store redundant information.

> +#define CFG_FLASH_CFI                           /* The flash is CFI compatible  */
> +#define CFG_FLASH_CFI_DRIVER                    /* Use common CFI driver        */

Indentation not by TABs... (here and at othe rplaces).



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Even if you can deceive people about  a  product  through  misleading
statements, sooner or later the product will speak for itself.
- Hajime Karatsu




More information about the U-Boot mailing list