[U-Boot-Users] [PATCH] xsengine: Fix no partition type specified, use DOS as default

[Wolfgang Denk]

In message <1192768425-12791-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> 
> diff --git a/board/xsengine/flash.c b/board/xsengine/flash.c
> index 2b9afc7..a188e24 100644
> --- a/board/xsengine/flash.c
> +++ b/board/xsengine/flash.c
> @@ -46,11 +46,11 @@ unsigned long flash_init (void)
>  	for (i = 0; i < CFG_MAX_FLASH_BANKS; i++) {
>  		switch (i) {
>  		case 0:
> -			flash_get_size ((long *) PHYS_FLASH_1, &flash_info[i]);
> +			flash_get_size ((vu_long *) PHYS_FLASH_1, &flash_info[i]);
>  			flash_get_offsets (PHYS_FLASH_1, &flash_info[i]);
>  			break;
>  		case 1:
> -			flash_get_size ((long *) PHYS_FLASH_2, &flash_info[i]);
> +			flash_get_size ((vu_long *) PHYS_FLASH_2, &flash_info[i]);
>  			flash_get_offsets (PHYS_FLASH_2, &flash_info[i]);

Ummm... you did not mention this change in your Subject.

That's not good. It would be better to split this into 2  independent
commits.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I knew then (in 1970) that a 4-kbyte minicomputer would cost as much
as a house. So I reasoned  that  after  college,  I'd  have  to  live
cheaply in an apartment and put all my money into owning a computer."
      - Apple co-founder Steve Wozniak, EE Times, June 6, 1988, pg 45