[U-Boot-Users] 83xx: fix CFG_ENV_ADDR and CFG_ENV_SECT_SIZE definitions

Jens Gehrlein sew_s at tqs.de
Wed Oct 31 17:14:00 CET 2007


Timur Tabi wrote:
> Jens Gehrlein wrote:
> 
>> IMHO this would work only if the sum of
>> CFG_MONITOR_BASE + CFG_MONITOR_LEN is sector aligned.
>> Did you set CFG_MONITOR_LEN appropriately?
>> (Just to avoid unexpected behaviour)
> 
> I'm under the assumption that CFG_MONITOR_LEN is always supposed to be a 
> multiple of the sector size.  Should I add comments to the header files 
> to state that explicitly?
> 
It's just, because I saw implementations, where CFG_MONITOR_LEN was an
arbitrary value. It depends on how the developer interpretes this
define and how it is used in the cpu and board specific code.

Maybe a comment would help, but I leave the decision to you.

Best regards
   Jens





More information about the U-Boot mailing list