[U-Boot-Users] [PATCH 5/5] OneNAND support

[Kyungmin Park]

> 
> > > This should probably be 0 for production code?
> > >
> > > > +#ifdef ONENAND_DEBUG
> > > > +#define DEBUG(level, args...)						\
> > > > +do {									\
> > > > +	if (level <= DEBUG_LEVEL) {					\
> > > > +		printf(args);						\
> > > > +	}								\
> > > > +} while (0)
> > > > +#else
> > > > +#define DEBUG(level, args...)		do { } while (0)
> > > > +#endif
> > >
> > > Please do not reinvent yoru own debug macros, please use the existing
> > > ones instead.
> > >
> >
> > After new NAND implementation, there are required macro and filed.
> > I added <linux/mtd/compat.h> and <linux/mtd/mtd.h> headers at required files
> >
> > Others such as spinlock, wait_queue_head_t are typedef-ed.
> > In NAND case, it disabled it by "if 0".
> > And kvec also will be removed at next code update.
> 
> I still think you should NOT redefine DEBUG but instead use the
> existing definitions for debug() resp. debugX(); please see
> include/common.h

Yes, I *don't* redefine the DEBUG. Now it used DEBUG macro at linux/mtd/mtd.h

Thank you,
Kyungmin Park