[U-Boot-Users] [PATCH1] Microblaze - mfsl command reparation

Michal Simek Monstr at seznam.cz
Tue Sep 11 17:26:44 CEST 2007


>> Desc: mfsl command reparation

>Is this a bug fix?  It's not obvious from the patch or the description.

Yes. this is reparing command help information

>
> Signed-off-by: Michal Simek <monstr at monstr.eu>
>
> diff --git a/common/cmd_mfsl.c b/common/cmd_mfsl.c
> index 8d4c1a3..93cc873 100644
> --- a/common/cmd_mfsl.c
> +++ b/common/cmd_mfsl.c
> @@ -357,7 +357,7 @@ int do_rspr (cmd_tbl_t * cmdtp, int flag, int argc, char
*argv[])
>
>         reg = (unsigned int)simple_strtoul (argv[1], NULL, 16);
>         val = (unsigned int)simple_strtoul (argv[2], NULL, 16);
> -       if (argc < 1) {
> +       if (argc < 2) {

>Shouldn't the check for the number of arguments occur *before* the
>strtoul() calls?

Yes this is bug. I will fix it.

M




More information about the U-Boot mailing list