[U-Boot-Users] [PATCH9] microblaze EMAC support

Wolfgang Denk wd at denx.de
Wed Sep 12 21:46:56 CEST 2007


In message <2111.4027-22284-1365301341-1189525568 at seznam.cz> you wrote:
> > DESC: Xilinx Emac support
> >
> > Signed-off-by: Michal Simek <monstr at monstr.eu>
> 
> > Another good looking driver.  All my comments are minor ones.
> :-)
> 
> >This isn't used anywhere but xilinx_emac.c.  I'd just roll them into
> >the same file.
> It's question for Wolfgang instead of me. Could you comment it? What is the better way?

I don't know how likely it is that this code might ever  be  used  by
some  other  sources, so factoring out makes sense. If it's unlikely,
then roll it into one.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is undignified for a woman to play servant to a man who is not
hers.
	-- Spock, "Amok Time", stardate 3372.7




More information about the U-Boot mailing list