[U-Boot-Users] [PATCH] [ARM] Fix DECLARE_GLOBAL_DATA_PTR and make gd global

Wolfgang Denk wd at denx.de
Sat Sep 15 09:43:03 CEST 2007


In message <46EB7145.1050307 at googlemail.com> you wrote:
>
> Some users [1] with (some?) ARM toolchains report issues with
> #define DECLARE_GLOBAL_DATA_PTR     register volatile gd_t *gd asm ("r8")
> in include/asm-arm/global_data.h
> The issue seems to be [2]

Can you please point out specific boards that show this problem?

> This patch makes DECLARE_GLOBAL_DATA_PTR empty, so no local register
> variable any more, and makes gd global.

Actually this should not be  needed  any  more  as  all  use  of  the
DECLARE_GLOBAL_DATA_PTR  (should)  have  been  moved outside function
bodies, so we already use a global definition. If there are remaining
places where this has been forgotten I'd rather fix these.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Youth doesn't excuse everything.
	-- Dr. Janice Lester (in Kirk's body), "Turnabout Intruder",
	   stardate 5928.5.




More information about the U-Boot mailing list