[U-Boot-Users] [PATCH] 85xx io out functions need sync after write.

Swarthout Edward L-SWARTHOU ed.swarthout at freescale.com
Thu Sep 27 08:25:50 CEST 2007


From: Stefan Roese
>
> On Wednesday 26 September 2007, Ed Swarthout wrote:
> > This fixes the mc146818 rtc_read/write functions for 85xx.
> >
> > --- a/cpu/mpc85xx/start.S
> >  out8:
> >  	stb	r4,0x0000(r3)
> > +	sync
> 
> Another way would be to use the out_be32() and friends functions 
> defined in asm-ppc/io.h. They already have the sync/barrier included 
> and are recommened for accessing peripheral devices.

Agreed, but grep finds 132 calls to out[813] in driver and rtc files.

I only noticed the missing sync's when debugging a failing "date" 
command that uses rtc/mc145818.

-Ed





More information about the U-Boot mailing list