[U-Boot-Users] [PATCH/review] Blackfin: resurrect BF533-STAMP video splash driver

[Wolfgang Denk]

In message <20080410111625.GG28294 at game.jcrosoft.org> you wrote:
>
...
> > +typedef struct {
> > +	unsigned int SAV;
> > +	unsigned int EAV;
> > +} SystemCodeType;
 ^^^^^^^^^^^^^^^^^^^^^
> > +
> > +const SystemCodeType SystemCodeMap[4] = {
 ^^^^^^^^^^^^^^^^^^^^^^^^^
> > +	{0xFF000080, 0xFF00009D},
> > +	{0xFF0000AB, 0xFF0000B6},
> > +	{0xFF0000C7, 0xFF0000DA},
> > +	{0xFF0000EC, 0xFF0000F1}
> > +};
> > -- 
> Personnaly, I do not like var name that strart with UPPERCASE

It's more than not liking. It's a clear violation of the coding style:

    C is a Spartan language, and so should your naming be.  Unlike Modula-2
    and Pascal programmers, C programmers do not use cute names like
    ThisVariableIsATemporaryCounter.  A C programmer would call that
    variable "tmp", which is much easier to write, and not the least more
    difficult to understand.

So this is a clear NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nothing is easier than to denounce  the  evildoer;  nothing  is  more
difficult than to understand him.                 - Fyodor Dostoevski