[U-Boot-Users] [PATCH 1/2] Don't panic if a controller driver does ecc its own way.

[Scott Wood]

Wolfgang Denk wrote:
> In message <20080414163455.GA7061 at ld0162-tx32.am.freescale.net> you wrote:
>>>> Some hardware, such as the enhanced local bus controller used on some
>>>> mpc83xx chips, does ecc transparently when reading and writing data, rather
>>>> than providing a generic calculate/correct mechanism that can be exported to
>>>> the nand subsystem.
>>>>
>>>> The subsystem should not BUG() when calculate, correct, or hwctl are
>>>> missing, if the methods that call them have been overridden.
>>>>
>>>> Signed-off-by: Scott Wood <scottwood at freescale.com>
>>> This should go through the 83xx custodian, but I haven't seen this
>>> yet?
>> Why should it go through 83xx?  It's a patch against generic NAND code.
> 
> It seems to be 83xx specific code to me?

It's not.  It is removing a restriction in the NAND code that happens to 
interfere with what the FSL NAND driver needs to do.

>> Did you try applying it against the 2.6.22.1 branch of the nand
>> repository (IIRC, the non-commit-message patch comment specified that)?
> 
> No, I tried to apply this to the U-Boot repository. Maybe this was my
> fault? Is this supposed to go into Linux, then?

No, it's supposed to go into the 2.6.22.1 branch of Stefan's u-boot NAND 
tree.  This change is already in the Linux NAND code.

-Scott