[U-Boot-Users] [PATCH v2 3/7] add an i2c driver for mx31

[Grant Likely]

On Mon, Apr 14, 2008 at 5:28 PM, Guennadi Liakhovetski <lg at denx.de> wrote:
> On Mon, 14 Apr 2008, Wolfgang Denk wrote:
>
>  > In message <20080414064659.GB17663 at game.jcrosoft.org> you wrote:
>  > >
>  > > > +#if defined(CONFIG_HARD_I2C) && defined (CONFIG_I2C_MXC)
>  > > Please stop to define this here, move it the Makefile
>  >
>  > Hm... While I agree with the simple standard case of a single
>  > "#ifdef", I'm not so 100% sure it is a good thing to add such complex
>  > expressions to the Makefile.
>  >
>  > Aren't we just moving the #ifdef hell from one place to another?
>
>  Wouldn't it be logical to assume, that if CONFIG_I2C_MXC is defined,
>  CONFIG_HARD_I2C is meant too? So, we could just put in i2c.h
>
>  #ifdef CONFIG_I2C_MXC
>  #define CONFIG_HARD_I2C
>  #endif
>
>  And then use the simple
>
>  OBJC-$(CONFIG_I2C_MXC) += ...
>

Yes, this is the way I'd solve the problem.

Cheers,
g.


-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.