[U-Boot-Users] [PATCH v2 3/7] add an i2c driver for mx31

[Wolfgang Denk]

In message <Pine.LNX.4.64.0804150024500.5332 at axis700.grange> you wrote:
> > 
> > Aren't we just moving the #ifdef hell from one place to another?
> 
> Wouldn't it be logical to assume, that if CONFIG_I2C_MXC is defined, 
> CONFIG_HARD_I2C is meant too? So, we could just put in i2c.h

Well, what exactly is CONFIG_I2C_MXC supposed to mean? Sorry for
asking, but I cannot find it documented anywhere (hint! hint! This
needs to be fixed!). I tend to believe that in it's current form it's
redundant, meaning that we have both CONFIG_CMD_I2C and CONFIG_MX31.

> #ifdef CONFIG_I2C_MXC
> #define CONFIG_HARD_I2C
> #endif

Depending on the intended meaning of CONFIG_I2C_MXC there could also
be someone who wants to use soft-I2C on that processors.

> in the Makefile? I personally do prefer when unneeded .c files do not get 
> compiled at all, rather than compiled to "0"-byte big objects. Makes the 
> build process and the resulting tree look cleaner, and the image a bit 
> smaller.

Me too.

But then, I definitely want to keep the Makefiles simple and clean,
too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"... freedom ... is a worship word..."
"It is our worship word too."
	-- Cloud William and Kirk, "The Omega Glory", stardate unknown